Skip to content

Fix: Workflow maintaining conda environment#146

Merged
fmalatino merged 15 commits intoNOAA-GFDL:developfrom
fmalatino:conda-ci
Sep 11, 2025
Merged

Fix: Workflow maintaining conda environment#146
fmalatino merged 15 commits intoNOAA-GFDL:developfrom
fmalatino:conda-ci

Conversation

@fmalatino
Copy link
Contributor

@fmalatino fmalatino commented Sep 11, 2025

Description
This PR ensures that the same shell is opened across workflow steps and no longer calls for removal of sqlite after installation.

Fixes:
Current failures in the workflow

How Has This Been Tested?
Tested using current set of unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

@fmalatino fmalatino marked this pull request as ready for review September 11, 2025 19:01
Copy link
Collaborator

@jjuyeonkim jjuyeonkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried out similar changes in my own PRs and can confirm that these fixes work on my tests as well.

(Side note: I wish we knew more in the first place about why the sqlite removal and oversubscribe were necessary before but are causing CI errors now. I remember needing to add the oversubscribe for previous PRs. )

Copy link
Collaborator

@oelbert oelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fmalatino fmalatino added this pull request to the merge queue Sep 11, 2025
Merged via the queue into NOAA-GFDL:develop with commit f092591 Sep 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants