Removing ndsl.Namelist from Pace#158
Merged
fmalatino merged 2 commits intoNOAA-GFDL:developfrom Oct 30, 2025
Merged
Conversation
fmalatino
approved these changes
Oct 30, 2025
romanc
approved these changes
Oct 30, 2025
Collaborator
romanc
left a comment
There was a problem hiding this comment.
This looks great! Thanks for the cleanup 🧹
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PhysicsConfigcreation, usingPhysicsConfig.from_dictinstead.This follows from PySHiELD PR #68, PyFV3 PR #88 and NDSL PR #246. It is part of NDSL Issue # 64.
This is intended to be the last PR before finally removing
ndsl.Namelist.How Has This Been Tested?
Checklist: