Skip to content

Removing ndsl.Namelist from Pace#158

Merged
fmalatino merged 2 commits intoNOAA-GFDL:developfrom
jjuyeonkim:20251030_namelist_cleanup
Oct 30, 2025
Merged

Removing ndsl.Namelist from Pace#158
fmalatino merged 2 commits intoNOAA-GFDL:developfrom
jjuyeonkim:20251030_namelist_cleanup

Conversation

@jjuyeonkim
Copy link
Collaborator

Description

  • Removes ndsl.Namelist from Pace
  • Cleans up direct dacite usage for PhysicsConfig creation, using PhysicsConfig.from_dict instead.

This follows from PySHiELD PR #68, PyFV3 PR #88 and NDSL PR #246. It is part of NDSL Issue # 64.

This is intended to be the last PR before finally removing ndsl.Namelist.

How Has This Been Tested?

  • Existing unit tests and CI translate tests pass.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

@jjuyeonkim jjuyeonkim marked this pull request as ready for review October 30, 2025 18:30
Copy link
Collaborator

@romanc romanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for the cleanup 🧹

@fmalatino fmalatino added this pull request to the merge queue Oct 30, 2025
Merged via the queue into NOAA-GFDL:develop with commit db1159c Oct 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants