Merged
Conversation
… are not optional fields
This breaks with Serializable's convention to only exclude `None` value fields.
The field_serializers Config option is a apping of field name to callable that changes the default serialized form of a field (i.e. to_dict, to_json, dict, json). This is often helpful when a field requires a use case specific representation (i.e. datetime) or is not JSON serializable. For example, if a field is a datetime type, this feature enables changing how that datetime object is serialized (e.g. ISO8601 with only seconds). The main intent of this feature is to discourage subclasses from overriding `dict` to implement use case specific serialization and provide a pathway to achieve this.
This was referenced Jun 7, 2023
Optimizing field data structure types, __init__, and property implementations for SimpleHydrofabricSubset.
This was referenced Jun 7, 2023
Member
|
@christophertubbs, @robertbartel, I think ive addressed all of the comments from @christophertubbs's first review. @robertbartel, are we ready to proceed with the merge? |
Member
|
This is a bit of an aside, for those that want to read more about the foundational changes to |
christophertubbs
approved these changes
Jun 7, 2023
Contributor
|
Rebase it, chief. Great job to the both of you. |
This was referenced Jun 9, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bringing Pydantic implementation into the
masterbranch.This builds off the existing feature branch
pydantic-serializable, rebasing recent commits, resolving merge conflicts, resolving design and implementation conflicts, ensuring functionality is working as needed (confirmed by tests), etc.