Skip to content

Fix Discount#95

Merged
CTH999 merged 75 commits intointegrate-discountfrom
add-discount
Feb 21, 2025
Merged

Fix Discount#95
CTH999 merged 75 commits intointegrate-discountfrom
add-discount

Conversation

@CTH999
Copy link
Copy Markdown
Collaborator

@CTH999 CTH999 commented Feb 21, 2025

For some reason the discount seems to be not fully working... so, trying to fix it

run

didin't work
@CTH999 CTH999 changed the base branch from Husam-code1 to integrate-discount February 21, 2025 13:50
@CTH999 CTH999 added this to the fix discount milestone Feb 21, 2025
@CTH999 CTH999 linked an issue Feb 21, 2025 that may be closed by this pull request
@CTH999 CTH999 removed a link to an issue Feb 21, 2025
@CTH999 CTH999 linked an issue Feb 21, 2025 that may be closed by this pull request
Closed
@CTH999 CTH999 changed the title Modify Discount Fix Discount Feb 21, 2025
delete the .vs folder
this is the visual studio version, renamed for ease of access
this is the github version, renamed for ease of access
replace the explanation with a quick little note
rename note so that the name is the same as the contents
This reverts commit c7fdf42.
moved the current .gitignore into the folder being used for edits
the current .gitignore was probally the auto-generated visual-studio one. to determine the acuracy of that theory, the previous .vs one was deleted, and the .github one renamed.

If there where any diff's, then they wouldn't be the same.
the answer was "they are the same"

either way, reverted, just to be safe
update to VisualStudio preset

Signed-off-by: Um... Figure it out! <33612115+CTH999@users.noreply.github.com>
add in the part that's auto-generated by VS

Signed-off-by: Um... Figure it out! <33612115+CTH999@users.noreply.github.com>
renamed the old .gitignore so it overwrites the newest .gitignore.

They, interestingly, do have differences. Neat, eh?
to check if the system has .vsidx inherently in it, a simple test is being done;

undo the manual addition, search if that part exists, if it doesn't, redo manual addition
a copy and paste of the online one
rename the .gitignore. there is a difference, but what it is, I don't know. it appears negligible
Reset the .gitignore to the most recent one from github
this part allows for a direct ignore of the file. Not sure if that's good, bad, or neither. Still, added
Signed-off-by: Um... Figure it out! <33612115+CTH999@users.noreply.github.com>
the component that will allow for the system to ignore the folder, completley
the internal framework that is behind the capibility of the transfer folder to work
This reverts commit 30b76db.
transfer in the minute changes from Initial
Delete New Text Document.txt
This reverts commit 0bbc88c.
delete files that are ignored by .gitignore
* delete-ignored:
  delete ignored
realized that by seting the subtotal based on a multiplied version of itself, each calculation itterativly discounted the discount...

so, the soultion? well, you have to do the opposite, of course! so, divide by discount
modified it so the variables have the math executed inside the string
the simplest way to update the prices as soon as you click the coupon; just use the exact same code as used for the main method of setting it.

In a perfect world, I would either trigger the method, but without changeing the value; or would make a new method for the price, and use that
some code that might (or might not) have been deleted. So, transfered here
discount code somehow got deleted. re-added it
just in case, made this part set subtotal to 0
@CTH999 CTH999 merged commit ea1fce6 into integrate-discount Feb 21, 2025
@CTH999 CTH999 deleted the add-discount branch February 21, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix

1 participant