Skip to content

Enhance run_bigscape for BiG-SCAPE v2 compatibility#349

Merged
CunliangGeng merged 7 commits intodevfrom
fix_bigscape
Mar 13, 2026
Merged

Enhance run_bigscape for BiG-SCAPE v2 compatibility#349
CunliangGeng merged 7 commits intodevfrom
fix_bigscape

Conversation

@CunliangGeng
Copy link
Copy Markdown
Member

@CunliangGeng CunliangGeng commented Mar 12, 2026

BiG-SCAPE v2 compatibility improvements:

  • Updated BiG-SCAPE v2 from v2.0.0.beta5 to v2.0.2
  • Updated the executable name for BiG-SCAPE v2 from bigscape-v2.py to bigscape in run_bigscape.py to match the new release convention.
  • Added logic to convert underscores to hyphens in command-line option names for BiG-SCAPE v2, as required by its Click-based CLI, while preserving underscores for v1 (argparse-based).

Output file handling:

  • Modified _run_bigscape in arranger.py to correctly locate and copy the BiG-SCAPE v2 output database, which is now named after the output directory, ensuring consistent downstream file usage.

@CunliangGeng CunliangGeng requested a review from liannette March 12, 2026 21:35
@CunliangGeng CunliangGeng self-assigned this Mar 12, 2026
@CunliangGeng CunliangGeng marked this pull request as draft March 12, 2026 21:50
@CunliangGeng CunliangGeng marked this pull request as ready for review March 12, 2026 22:00
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
77.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link
Copy Markdown
Contributor

@liannette liannette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@CunliangGeng CunliangGeng merged commit 4f333b4 into dev Mar 13, 2026
7 of 10 checks passed
@CunliangGeng CunliangGeng deleted the fix_bigscape branch March 13, 2026 11:27
@github-project-automation github-project-automation bot moved this to Done in dev Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants