"Sort by key" causes the value type to change

[iyangchengye]

Hi,

When I use the "Sort by key" function, after sorting, it converts the number type to a string type.
See "age" in the example below.

Before sorting
{ "name": "Ycy", "age": 27, "is_student": false }

After sorting
{ "age": "27", "is_student": false, "name": "Ycy" }

My plugin version is 2.1.1.0 and npp version is 8.8.5
Looking forward to your reply, thx.

[AntonDevil]

I investigated the issue a little bit.

Here is the test for it (can be added to JsonHandlerTest.cpp):

    TEST_F(JsonHandlerTest, TestSortJsonByKey_NumberValue_Success)
    {
        std::string inputJson = R"({"b": "valueB", "a": 30})";
        auto        result    = m_jsonHandler.SortJsonByKey(inputJson, {}, {}, ' ', 4);

        ASSERT_TRUE(result.success);
        ASSERT_EQ(result.response, "{\n    \"a\": 30,\n    \"b\": \"valueB\"\n}");
    }

Indeed, it won't pass, because it will output {"a": "30", "b": "valueB"}

The root cause is the line JsonHandler.h:29
constexpr auto flgBaseReader = rj::kParseEscapedApostropheFlag | rj::kParseNanAndInfFlag | rj::kParseNumbersAsStringsFlag;
Note rj::kParseNumbersAsStringsFlag
When JsonHandler.cpp:108 SortJsonText read json it treats numbers as string (as an attempt to preserve whatever number there was even if it's too long to be parsed precisely) and outputs it as string.

I'm not a maintainer of this repo (just joined) and I didn't figure out a good and simple solution yet.

[AntonDevil]

There was an attempt to support this:
RawNumber() inconsistent about quotes
But there were some problem about it Write RawNumber without quotes

Since RapidJSON dependency come from a fork by @SinghRajenM (main maintainer)
I can suggest to fix this in this fork and keep a list of patches applied to keep track of this for future syncs with the main RapidJSON repo