Skip to content

Fix RawNumber write #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SinghRajenM merged 1 commit into from
Mar 21, 2026
Merged

Fix RawNumber write #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion external/rapidjson
Open in desktop
Submodule rapidjson updated 6 files
+4 −0 include/rapidjson/document.h
+1 −1 include/rapidjson/prettywriter.h
+1 −1 include/rapidjson/writer.h
+59 −0 test/unittest/documenttest.cpp
+19 −0 test/unittest/prettywritertest.cpp
+25 −0 test/unittest/writertest.cpp
31 changes: 21 additions & 10 deletions tests/UnitTest/JsonSortByKeyTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@

#include "JsonHandler.h"

// TODO: Adjust test case when numeric values are properly supported in SortJsonByKey

namespace JsonSortByKey
{
class JsonSortByKeyTest : public ::testing::Test
Expand Down Expand Up @@ -43,13 +41,13 @@ namespace JsonSortByKey
auto result = m_jsonHandler.SortJsonByKey(inputJson, {}, {}, ' ', 4);

ASSERT_TRUE(result.success);
ASSERT_EQ(result.response, "{\n \"a\": \"30\",\n \"b\": \"valueB\"\n}");
ASSERT_EQ(result.response, "{\n \"a\": 30,\n \"b\": \"valueB\"\n}");

std::string inputJson2 = R"({ "name": "My name?", "age": 27, "is_student": false })";
auto result2 = m_jsonHandler.SortJsonByKey(inputJson2, {}, {}, ' ', 2);

ASSERT_TRUE(result2.success);
ASSERT_EQ(result2.response, "{\n \"age\": \"27\",\n \"is_student\": false,\n \"name\": \"My name?\"\n}");
ASSERT_EQ(result2.response, "{\n \"age\": 27,\n \"is_student\": false,\n \"name\": \"My name?\"\n}");
}

TEST_F(JsonSortByKeyTest, TestSortJsonByKey_NaN_Value_Success)
Expand All @@ -58,7 +56,7 @@ namespace JsonSortByKey
auto result = m_jsonHandler.SortJsonByKey(inputJson, {}, {}, ' ', 4);

ASSERT_TRUE(result.success);
ASSERT_EQ(result.response, "{\n \"Hello\": \"World\",\n \"Nan\": \"NaN\"\n}");
ASSERT_EQ(result.response, "{\n \"Hello\": \"World\",\n \"Nan\": NaN\n}");
}

TEST_F(JsonSortByKeyTest, TestSortJsonByKey_ArrayValue_Success)
Expand All @@ -67,7 +65,7 @@ namespace JsonSortByKey
auto result = m_jsonHandler.SortJsonByKey(inputJson, {}, LF::kFormatSingleLineArray, ' ', 2);

ASSERT_TRUE(result.success);
ASSERT_EQ(result.response, "{\n \"Inf\": [\"-Infinity\", \"Infinity\", \"-Infinity\", \"Infinity\"],\n \"text\": [\"Hello\", \"World\"]\n}");
ASSERT_EQ(result.response, "{\n \"Inf\": [-Infinity, Infinity, -Infinity, Infinity],\n \"text\": [\"Hello\", \"World\"]\n}");
}

TEST_F(JsonSortByKeyTest, TestSortJsonByKey_EmptyObject)
Expand All @@ -85,7 +83,7 @@ namespace JsonSortByKey
auto result = m_jsonHandler.SortJsonByKey(inputJson, {}, {}, ' ', 2);

ASSERT_TRUE(result.success);
ASSERT_EQ(result.response, "{\n \"a\": {\n \"c\": \"3\"\n },\n \"z\": {\n \"a\": \"1\",\n \"b\": \"2\"\n }\n}");
ASSERT_EQ(result.response, "{\n \"a\": {\n \"c\": 3\n },\n \"z\": {\n \"a\": 1,\n \"b\": 2\n }\n}");
}

TEST_F(JsonSortByKeyTest, TestSortJsonByKey_SpecialCharacters)
Expand All @@ -94,7 +92,7 @@ namespace JsonSortByKey
auto result = m_jsonHandler.SortJsonByKey(inputJson, {}, {}, ' ', 2);

ASSERT_TRUE(result.success);
ASSERT_EQ(result.response, "{\n \"!\": \"1\",\n \"#\": \"2\",\n \"A\": \"3\"\n}");
ASSERT_EQ(result.response, "{\n \"!\": 1,\n \"#\": 2,\n \"A\": 3\n}");
}

TEST_F(JsonSortByKeyTest, TestSortJsonByKey_UnicodeKeys)
Expand All @@ -103,7 +101,7 @@ namespace JsonSortByKey
auto result = m_jsonHandler.SortJsonByKey(inputJson, {}, {}, ' ', 2);

ASSERT_TRUE(result.success);
ASSERT_EQ(result.response, "{\n \"α\": \"1\",\n \"β\": \"2\",\n \"γ\": \"3\"\n}");
ASSERT_EQ(result.response, "{\n \"α\": 1,\n \"β\": 2,\n \"γ\": 3\n}");
}

TEST_F(JsonSortByKeyTest, TestSortJsonByKey_NullValue)
Expand All @@ -123,7 +121,7 @@ namespace JsonSortByKey
auto result = JsonHandler {options}.SortJsonByKey(inputJson, {}, {}, ' ', 2);

ASSERT_TRUE(result.success);
ASSERT_EQ(result.response, "{\n \"a\": \"1\",\n \"b\": \"2\"\n}");
ASSERT_EQ(result.response, "{\n \"a\": 1,\n \"b\": 2\n}");
}

TEST_F(JsonSortByKeyTest, TestSortJsonByKey_IgnoreTrailingComma)
Expand All @@ -135,4 +133,17 @@ namespace JsonSortByKey

ASSERT_FALSE(result.success);
}

TEST_F(JsonSortByKeyTest, TestSortJsonByKey_NumberPrecision_Success)
{
// Verify numbers survive the sort-by-key roundtrip without gaining quotes.
// Note: SortJsonByKey re-parses via FormatJson (which uses kParseFullPrecisionFlag),
// so very high precision may be normalized (e.g. 0.00000000000001 -> 1e-14).
// But they must NOT become strings (e.g. "3.14" or "12345678901234567890").
std::string inputJson = R"({"z": "last", "pi": 3.141592653589793, "tiny": 1e-14, "tiny2": 0.00000000000001, "big": 12345678901234567890})";
auto result = m_jsonHandler.SortJsonByKey(inputJson, {}, {}, ' ', 2);

ASSERT_TRUE(result.success);
ASSERT_EQ(result.response, "{\n \"big\": 12345678901234567890,\n \"pi\": 3.141592653589793,\n \"tiny\": 1e-14,\n \"tiny2\": 1e-14,\n \"z\": \"last\"\n}");
}
} // namespace JsonSortByKey
Loading