Skip to content

Conversation

@vancekic
Copy link
Contributor

@vancekic vancekic commented Aug 6, 2015

Consider this very simple faulty json :
{"a":1}}

This fixes pull will fix the hangup and display :
{
"a": 1
}
}
as it should.

@vancekic vancekic changed the title Fix #3 Notepad hanging with faulty json Fix #5 Notepad hanging with faulty json Aug 6, 2015
kapilratnani added a commit that referenced this pull request Aug 7, 2015
Fix #5 Notepad hanging with faulty json
@kapilratnani kapilratnani merged commit bb1d870 into NPP-JSONViewer:master Aug 7, 2015
@kapilratnani
Copy link
Collaborator

Thanks. Merged.

@kapilratnani
Copy link
Collaborator

You can test the latest build in the project's release page. I've posted a binary.

@vancekic vancekic deleted the fix branch August 7, 2015 13:55
@vancekic
Copy link
Contributor Author

vancekic commented Aug 7, 2015

I've been using the fix for two days, and it's all good as far as I can see.
Do you have json tests to run ? I could contribute to test them if you want.

@kapilratnani
Copy link
Collaborator

Well, i don't have any automated tests. It would be great if you can contribute.

@vancekic
Copy link
Contributor Author

vancekic commented Aug 7, 2015

I am only really using the "Format JSON" function but I am using it every day and it works fine with a wide variety of json so far. At least there's no obvious problem and certainly no hangup anymore.
Looking at the code, everything seems in order.

Your latest release is certainly more stable than the previous one from my point of view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants