1679 dual duct by kbenne · Pull Request #1707 · NatLabRockies/OpenStudio

kbenne · 2015-06-30T22:23:27Z

I'm finally done! Going to need some substantial testing on this. Lots of low level stuff going on. Things of interest for review.

https://github.com/NREL/OpenStudio-resources/blob/EnergyPlus-8-3-0/model/simulationtests/dual_duct.rb#L20

https://github.com/NREL/OpenStudio/blob/1679-DualDuct/openstudiocore/src/model/AirLoopHVAC.hpp#L73

https://github.com/NREL/OpenStudio/blob/1679-DualDuct/openstudiocore/src/model/test/AirLoopHVAC_GTest.cpp#L716

https://github.com/NREL/OpenStudio/blob/1679-DualDuct/openstudiocore/src/model/test/Plenums_GTest.cpp#L133

https://github.com/NREL/OpenStudio/blob/1679-DualDuct/openstudiocore/src/model/test/AirTerminalDualDuctVAV_GTest.cpp#L53

No UI support yet.

Update ConnectorSplitter::addToNode to allow a drop on the supply side of AirLoopHVAC. When this happens a new supply outlet node will be added in addition to the existing one. Demand side impacts have not been addressed yet in this work.

This (likely) completes api changes to support dual duct on the air loop supply side. New methods have been enabled including... - ::supplySplitter - ::supplySplitterInletNode - ::supplySplitterOutletNodes - Method implementations for supplyComponents and supplyComponent have been updated to traverse both legs of the dual duct, but the interface remains ths same. - supplyOutletNodes has been moved from AirLoopHVAC down to the base Loop class. - Added more const correctness. i- Added tests.

Add additional demand inlet node and related API. Add some tests, however some are failing and some existing tests have regressed. Need to review and correct in a later commit.

Fix error introduced here c20eeb2

This connects half of the terminal up to the demand side of AirLoopHVAC. Second leg of terminal remains unconnected.

This completes the loop for a dual duct sysetm. Adding AirTerminalDualDuctVAV to a zone inlet node will make the demand side "dual duct" with two demand inlet nodes and two zone splitters. If the system is already dual duct, ::addToNode will connect the inlets of the dual duct terminal up to the existing zone splitters. Most of AirTerminalDualDuctVAV::addToNode is implemented privately in AirLoopHVAC_Impl::addDualDuctTerminalToNode, so that other dual duct terminal types can share this implementation.

AirLoopHVAC::supplyMixerInletNodes ::supplyMixerOutletNode

Cleanup in a way that preserves backwards compatibility.

In ForwardTranslateAirLoopHVAC, make sure to translate both the supplySideOutletNodes and the demandSideInletNodes into respective nodes lists.

Instead of lumping all components on a single supply path, create one supply path for each leg of a possible dual duct system.

At this point dual duct systems will translate cleanly and simulate with energyplus. More commits will follow to cleanup code, ensure plenums work, remove supply splitter to go back to single duct, and perhaps other cleanups.

This is particularly important because clone can happen behind the scenes when you addBranchForZone.

nrel-bot · 2015-07-08T00:07:43Z