1761 add zonehvac#1773
Merged
Merged
Conversation
Still need to finish 3 ForwardTranslators
I think there are still forward translator errors but need to write simulation tests to know for sure.
This is a rework to ZoneHVACComponent::thermalZone ::addToThermalZone and ::removeFromThermalZone to handle both air based and non air based equipment. This means equipment that is connected to zone through nodes as well as equipment that is not. This prevents having to reimplement these methods in derived classes. Existing class reimplmentations have been left in place because they are working, but they might be removed in the future because they are unnecessary.
Contributor
|
@mbadams5 I will come back to write new integration tests. I ran existing unit and integration tests and will reintegrate this to develop. |
kbenne
force-pushed
the
1761_add_zonehvac
branch
from
August 19, 2015 21:03
40d20c6 to
daa5285
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the following ZoneHVAC objects...
ZoneHVAC:Dehumidifier:DX
ZoneHVAC:EnergyRecoveryVentilator:Controller
ZoneHVAC:EnergyRecoveryVentilator
ZoneHVAC:UnitVentilator
ZoneHVAC:Baseboard:RadiantConvective:Water
ZoneHVAC:Baseboard:RadiantConvective:Electric
A few things still todo:
Fixes #1761