Skip to content

Conversation

@pesap
Copy link
Collaborator

@pesap pesap commented Feb 2, 2025

No description provided.

@pesap pesap self-assigned this Feb 2, 2025
@pesap pesap added the Bug Something isn't working label Feb 2, 2025
@pesap pesap added this to the R2X v.1.1.0 milestone Feb 2, 2025
@pesap pesap marked this pull request as ready for review February 2, 2025 21:57
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 63.01370% with 27 lines in your changes missing coverage. Please review.

Project coverage is 78.51%. Comparing base (b0ef7de) to head (1833210).

Files with missing lines Patch % Lines
src/r2x/upgrader/functions.py 33.33% 20 Missing ⚠️
src/r2x/parser/handler_utils.py 81.25% 6 Missing ⚠️
src/r2x/parser/handler.py 90.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (63.01%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
- Coverage   78.83%   78.51%   -0.32%     
==========================================
  Files          39       40       +1     
  Lines        4025     4068      +43     
==========================================
+ Hits         3173     3194      +21     
- Misses        852      874      +22     
Files with missing lines Coverage Δ
src/r2x/utils.py 57.91% <100.00%> (ø)
src/r2x/parser/handler.py 87.61% <90.00%> (+1.32%) ⬆️
src/r2x/parser/handler_utils.py 81.25% <81.25%> (ø)
src/r2x/upgrader/functions.py 80.48% <33.33%> (-15.22%) ⬇️

@pesap pesap merged commit cd0863e into main Feb 2, 2025
8 checks passed
@pesap pesap deleted the ssh/hdf5upgrade branch February 2, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: load.h5 file is not readable with pd.read_hdf with latest version of ReEDS

4 participants