Skip to content

Conversation

@jarry7
Copy link
Contributor

@jarry7 jarry7 commented Mar 8, 2025

Small changes to get ThermalMultiStart working (imports)

@jarry7 jarry7 requested a review from pesap March 8, 2025 00:38
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.15%. Comparing base (e962dec) to head (c83ce6a).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/r2x/models/generators.py 90.90% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
- Coverage   82.16%   82.15%   -0.01%     
==========================================
  Files          42       42              
  Lines        4318     4344      +26     
==========================================
+ Hits         3548     3569      +21     
- Misses        770      775       +5     
Files with missing lines Coverage Δ
src/r2x/models/__init__.py 100.00% <100.00%> (ø)
src/r2x/models/named_tuples.py 100.00% <100.00%> (ø)
src/r2x/models/generators.py 98.29% <90.90%> (-0.78%) ⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jarry7 jarry7 added the enhancement New feature or request label Mar 8, 2025
@jarry7 jarry7 self-assigned this Mar 8, 2025
@jarry7 jarry7 marked this pull request as draft March 8, 2025 00:53
@pesap pesap marked this pull request as ready for review March 11, 2025 20:18
@pesap pesap merged commit 2b67581 into main Mar 11, 2025
8 checks passed
@pesap pesap deleted the jw/therm_multistart branch March 11, 2025 20:50
kodiobika pushed a commit that referenced this pull request Mar 19, 2025
Small changes to get `ThermalMultiStart` working (imports)

---------

Co-authored-by: Jarrad Wright <jwright2@nrel.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants