-
Notifications
You must be signed in to change notification settings - Fork 7
Include pyhive inside the chronify package #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
==========================================
- Coverage 91.59% 91.59% -0.01%
==========================================
Files 47 49 +2
Lines 4032 4043 +11
==========================================
+ Hits 3693 3703 +10
- Misses 339 340 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0e7f823 to
9ed7ae4
Compare
This is a workaround for the fact that the latest pyhive package is not published on pypi.org.
9ed7ae4 to
f511af0
Compare
elainethale
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me. I assume dsgrid will import pyhive after importing chronify (i.e., not carry around our own copy)?
pyproject.toml
Outdated
| # Required by pyhive | ||
| "future", | ||
| "python-dateutil", | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: blank line
dsgrid will not need to import pyhive. Pyhive gets registered with sqlalchemy when pyhive is loaded (indirectly through chronify now). Our software doesn't actually make calls to pyhive. |
Even better! |
320bcc8 to
d07c5a6
Compare
|
This PR was bypassed in favor of #56. I think that was a mistake because dependency groups cannot be used by users installing from pipy.org. I think we should use this instead. Users will be able to and get all functionality. |
Include pyhive inside the chronify package
This is a workaround for the fact that the latest pyhive code is not published on pypi.org. The latest published version has a bug fixed by this commit. The pyhive source code was donated to Apache Kyuubi some time ago. They have not yet released a new version with this fix. In order to publish chronify (and dsgrid) packages that support Apache Spark on pypi.org, we need this commit. (You cannot publish packages that install from git repositories.)
We do not know when the kyuubi project will release an official version.
This seems to be the least-bad solution out of some bad options. Also considered: