Fix problem when LBMS database has not synchronized #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartcampbell
requested review from
JunAishima,
Copilot,
padraic-shafer and
vshekar
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances error handling when cycle details are missing by wrapping proposal retrieval in try/except blocks and incorporating logging for both NSLS-II and LBMS facilities.
- Added try/except blocks around proposal fetching for NSLS-II and LBMS cycles.
- Introduced logging of LookupError conditions to report missing cycle details.
- Passed facility_name to the LBMS proposal fetch function call for targeted error handling.
JunAishima
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some error handling for when the underlying database does not contain the cycle details for a facility - this usually happens when the synchronization is not working.
There was also a bug in the code that wasn't actually getting the list of cycles for lbms facility but getting them for nsls2 instead.