-
Notifications
You must be signed in to change notification settings - Fork 13
General house keeping (update dependencies and clean out js assets) #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ust-cloud dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR focuses on general housekeeping by updating dependency references to the new consolidated static assets directory and removing unused web assets, primarily related to jQuery UI. Key changes include:
- Updating asset paths in template files (_layout.html and default.html) from external URLs and legacy locations to the consolidated “/static” path.
- Removing unused JavaScript assets and associated files (jQuery, jQuery UI package files, CSS themes, structure, and minified CSS).
Reviewed Changes
Copilot reviewed 98 out of 211 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/nsls2api/templates/shared/_layout.html | Updated DOE and BSA logo image sources to point to the consolidated /static/images/ directory. |
| src/nsls2api/templates/home/default.html | Replaced asset URLs and commented out unused script references; updated stylesheet paths to /static/ paths. |
| src/nsls2api/static/assets/jquery/jquery.js | Removed unused jQuery asset. |
| src/nsls2api/static/assets/jquery-ui/package.json | Removed unused jQuery UI package metadata file. |
| src/nsls2api/static/assets/jquery-ui/license.txt | Removed the jQuery UI license file as part of asset cleanup. |
| src/nsls2api/static/assets/jquery-ui/jquery-ui.theme.min.css | Removed unused jQuery UI theme CSS asset. |
| src/nsls2api/static/assets/jquery-ui/jquery-ui.structure.min.css | Removed unused jQuery UI structure CSS asset. |
| src/nsls2api/static/assets/jquery-ui/jquery-ui.min.css | Removed unused minified jQuery UI CSS asset. |
| src/nsls2api/static/assets/jquery-ui/css/ui-lightness/jquery-ui.min.css | Removed unused jQuery UI CSS asset for the “ui-lightness” theme. |
padraic-shafer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updates are generally self-explanatory, though what is the intent of commenting out some lines in the default HTML template?
Are these lines that are probably no longer needed; and this is a first pass to verify that?
|
I realised that the default template is just a hold over from the import from ITD webservices templates - so it's not need so I will delete it. |
I realised that I don't need any of the file - so i've deleted it! |
This PR is basically some house keeping ahead of tagging a new release. It includes...
/staticpath and updated html files./defaultroute as it was unused