Remove UPS Integration - Cleanup Unused Code #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove UPS configuration settings from Settings class - Remove universal_proposal_system from JobSyncSource enum - Remove ups_id field from Beamline model - Remove UPS environment variables from pytest.env - Remove UPS logging statement from main.py - Remove UPS static assets (ups_fav.png)
…to ups-decomission
Contributor
Author
aderbenev
requested changes
Oct 24, 2025
aderbenev
left a comment
aderbenev
left a comment
There was a problem hiding this comment.
Commented on a PASS-related piece. Also, removing the UPS branch from .github/workflows/docker-publish.yml might be suitable to add to this change set.
…ed pass api logger.
ambarb
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is removed -
Database analysis confirmed that all ups_id fields only contained empty strings or null values. This cleanup removes unused placeholder code that was never implemented, so there's no functional impact.