Skip to content

Fix mixed PGN comment annotations#32

Merged
NSStudent merged 1 commit into
developfrom
codex/comment-list-parser-mixed-annotations
May 15, 2026
Merged

Fix mixed PGN comment annotations#32
NSStudent merged 1 commit into
developfrom
codex/comment-list-parser-mixed-annotations

Conversation

@NSStudent
Copy link
Copy Markdown
Owner

Summary

  • parse adjacent PGN square and arrow annotations with trailing text in the same comment block
  • keep pure text comments on the existing parser path
  • add direct CommentListParser coverage and a PGNGameParser integration case

Tests

  • rtk swift test --filter CommentListParserTests
  • rtk swift test --filter PGNGameParserTests/calAndCslSameComment
  • rtk swift test

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
...Parsers/CommentParsers/MultipleCommentParser.swift 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NSStudent NSStudent merged commit 5a0616b into develop May 15, 2026
3 checks passed
@NSStudent NSStudent deleted the codex/comment-list-parser-mixed-annotations branch May 15, 2026 17:12
NSStudent added a commit that referenced this pull request May 15, 2026
Fix mixed PGN comment annotations (#32)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant