Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for ranking and displaying teams based on road travel time using Amazon Location Service routing, rather than just crow-flies (haversine) distance. It introduces a new helper for batch route fetching, integrates road-routing into the team suggestion engine, and updates the UI to show travel time calculations and allow users to enable road-routing in the config. The changes improve the accuracy of team suggestions and provide more informative feedback to users.
Road-routing integration:
batchRoute.jshelper to fetch road-routing summaries (distance and travel time) for multiple origin→destination pairs using Amazon Location Service, with robust error handling and geometry extraction.InstantTaskViewModelto cache route results per team, trigger route fetches when the instant-task dropdown opens, and re-rank teams using road travel time when enabled. Also added logic to cancel pending requests when the dropdown closes. [1] [2]Team suggestion engine enhancements:
TeamSuggestionEngine.jsto usetravelTimeSecondsas the proximity dimension when available, falling back to haversine distance otherwise. AddedproximityValueandfmtProximityhelpers for sorting and display, updated sorting and scoring logic, and improved summary lines to show travel time and road distance when routing data is present. [1] [2] [3] [4] [5] [6]UI and config updates:
bsDropdownOpento bridge Bootstrap dropdown events to an observable, enabling route fetches only while the dropdown is open. [1] [2] [3]suggestionUseRoutingto enable/disable road-routing for team suggestions, including persistence and reactive updates. [1] [2] [3] [4]