-
Notifications
You must be signed in to change notification settings - Fork 3
Triadic closure (Summer 2020 merge) #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: - Separated out tests based on components of the coordinator - Allow multiple people to be assigned (and able to participate) in a need -- dont block if someone is already on the need! - TODO: Allow user to be assigned to many Half Half Needs (rather than excluding users who are already assigned to other parts of the incident?)
Summary: - Issue: When checking for a needObject, we were checking in the experience, rather than the incident; this is problematic because the incident is what stores the updating contributionTypes. - Fix: Point to the incident, and for some reason if it can't find the newest needObject, still try to send experience level notifications.
…isually friendly and informative
…into bumped-extend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This merges the work of Collective Experiences for Relationship Progression into master. Doing so will give us access to these experiences on the master branch, while at the same time making it compatible to run any previous experiences
Trying to highlight the biggest technical differences and contributions here, given that there are likely multiple features/characteristics added over the past year
Winter + Spring 2019
Created triadic experiences for the Spring 2019 study! These can be found in
triadic_experiences.js.They include
createGroupCheers,createImitationGame,createDrinksTalk,moodMeteorologyWhile implementing these experiences, some changes were made to the underlying system
allowRepeatContributionsto the CE API schema?updateSubmissionmethod in theOCEManager/progressor.jsfor group cheers to handle the reactionsWinter + Spring 2020
Making the monster experience! This involves two stages of experiences from
monsterCreateto co-create an artifact, and then continuing to use that artifact in future experiences inmonsterStory.While implementing these experiences, some changes were made to the underlying system
Testing:
Any special instructions for testing the Triadic Experiences?
Special instructions for switching and still deploying other experiences from this branch: You can toggle which experiences are loaded into the database on startup by going to the
imports/api/Testing/testingconstants.jsfile. You can include the OCEs from Ryan's Summer 2019 study usingCHI20_DTR_EXPERIENCES, while by default theTRIADIC_EXPERIENCESare already included