Fix/yama/730 make modal responsive #737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubosaka
reviewed
May 10, 2024
view/next-project/src/components/sponsoractivities/OpenAddModalButton.tsx
Outdated
Show resolved
Hide resolved
…lButton.tsx Co-authored-by: Kubosaka <115447919+Kubosaka@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
対応Issue
resolve #730
概要
モーダルを開いた際に、閉じるボタンが押せなくなる問題を修正
モーダルの縦幅を90vhに制限し、以降は内部でスクロールする仕組みに変更しました。
OpenModalButtonにCSSを当てず、AddButtonに直接記述する方式に切り替えました。
画面スクリーンショット等
テスト項目
localhost:3000/sponsoractivitiesにアクセスできる。備考