教員の論理削除を追加 #775
Merged
教員の論理削除を追加 #775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…9-teacher-logical-delete
Kubosaka
reviewed
Jun 21, 2024
Collaborator
Kubosaka
left a comment
Kubosaka
left a comment
There was a problem hiding this comment.
いくつかコメントしました
→指摘してるくせに自分のコードができていなかったみたいです
Comment on lines
65
to
76
|
|
||
| export const del = async (url: string, data: number[]) => { | ||
| const res = await fetch(url, { | ||
| method: 'DELETE', | ||
| mode: 'cors', | ||
| headers: { | ||
| 'Content-Type': 'application/json', | ||
| }, | ||
| body: JSON.stringify({ deleteIDs: data }), | ||
| }); | ||
| return await res.status; | ||
| }; |
Collaborator
There was a problem hiding this comment.
これusersと共有みたいだし、まとめてもらってもいい？
…9-teacher-logical-delete
…Fes/FinanSu into feat/hikahana/769-teacher-logical-delete
Kubosaka
reviewed
Jun 26, 2024
| return res; | ||
| }; | ||
|
|
||
| export const dels = async (url: string, data: number[]) => { |
Collaborator
There was a problem hiding this comment.
関数名が分かりにくいので、multiDelとかにして欲しいです
Collaborator
|
コンフリクトの解消と、 |
added 2 commits
July 1, 2024 13:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
対応Issue
resolve #769
概要
teacherのカラムにis_deletedを追加し、これのbooleanで論理削除を行うようにした。
sql文のgetでis_deletedがfalseのものを取得するように修正した。
MultiDestoryを追加し、複数削除をできるようにした。
上に伴い、teachersの削除を複数で行えるようにチェックボックスを配置した。
画面スクリーンショット等
URLスクリーンショット
テスト項目
-vからのmake buildでteacherのカラムにis_deletedが追加されているかlocalhost:3000/teachersにアクセスし、教員の複数削除が行えるか備考
API作って満足してました。
これから削除するページ作ります。
ps.
teachersはあった。複数削除できるようにしてみた