-
Notifications
You must be signed in to change notification settings - Fork 2
Feat/kobayashi/creatingstories file/sponsoractivities 805 #853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Kubosaka
merged 16 commits into
develop
from
feat/kobayashi/CreatingstoriesFile/sponsoractivities-805
Jul 27, 2024
Merged
Feat/kobayashi/creatingstories file/sponsoractivities 805 #853
Kubosaka
merged 16 commits into
develop
from
feat/kobayashi/CreatingstoriesFile/sponsoractivities-805
Jul 27, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubosaka
reviewed
Jul 27, 2024
Collaborator
Kubosaka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
動作は問題なかったです
少しコメントしました
別ブランチでconstantが定義されているブランチをマージする必要があるかもですね
purchase_reportsのブランチ?ですかね
developにそれがマージされたらこのブランチにdevelopをマージしてください
Kubosaka
approved these changes
Jul 27, 2024
Collaborator
Kubosaka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
対応Issue
resolve #805
概要
画面スクリーンショット等
テスト項目
Storybookで以下のファイルを表示できるか
備考