請求書の編集機能の追加 #869
Merged
請求書の編集機能の追加 #869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TkymHrt
reviewed
Aug 11, 2024
Member
TkymHrt
left a comment
TkymHrt
left a comment
There was a problem hiding this comment.
正しく請求書の発行ができました！
値段のフォームだけ問題ありそうだったのでコメントしています。
| value={invoiceSponsorStyle.price} | ||
| onChange={(e) => { | ||
| onChangeSponsorStyle( | ||
| { ...invoiceSponsorStyle, price: Number(e.target.value) }, |
Member
There was a problem hiding this comment.
値段に誤って全角文字を入力すると、NaN表示になり修正が不可能になる問題があります。
Suggested change
| { ...invoiceSponsorStyle, price: Number(e.target.value) }, | |
| { | |
| ...invoiceSponsorStyle, | |
| price: isNaN(Number(e.target.value)) | |
| ? invoiceSponsorStyle.price | |
| : Number(e.target.value), | |
| }, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #868
概要
画面スクリーンショット等
URLテスト項目
備考