fix(tokens): sørge for at large desktop tar breakpoint på min-width 1… - #463
Merged
Conversation
…400px I dag er det et lite feil i breakpoints i .css filene. desktop-large burde bli på alt som er større enn 1400px, mens desktop på alt som er mellom 1200px og 1400px
Contributor
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-meadow-0c645bd03-463.westeurope.5.azurestaticapps.net |
github-actions Bot
pushed a commit
that referenced
this pull request
Mar 7, 2025
## [1.5.2](v1.5.1...v1.5.2) (2025-03-07) ### Bug Fixes * **tokens:** sørge for at large-desktop tar breakpoint på min-width 1400px ([#463](#463)) ([349072a](349072a))
Contributor
|
🎉 This PR is included in version 1.5.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Det er en liten feil i breakpoints i .css-filene. 'desktop-large' burde være for alt som er større enn 1400px, mens 'desktop' burde være for alt som er mellom 1200px og 1400px. I dag er det omvendt. Denne PR-en fikser problemet. Brukere skal ikke merke noen forskjell, fordi både desktop og desktop-large bruker de samme verdiene, men i fremtiden, dersom vi bestemmer oss for å sette nye breakpoints, kan dette påvirke arbeidet negativt. Det er viktig å fikse dette fordi vi informerte brukerne om hvordan breakpoints settes på Teams, og det ser ut som løsningen gjør tingene litt annerledes...
#mybad