Skip to content

feat(nve-dialog): erstatter Shoelace med native dialog-element#872

Merged
saldar-nve merged 2 commits into
release-v5.0.0from
nve-dialog-ikke-bruk-av-shoelace
May 21, 2026
Merged

feat(nve-dialog): erstatter Shoelace med native dialog-element#872
saldar-nve merged 2 commits into
release-v5.0.0from
nve-dialog-ikke-bruk-av-shoelace

Conversation

@saldar-nve

Copy link
Copy Markdown
Contributor

Breaking Changes

Før (Shoelace) Nå (native dialog)
sl-show, sl-after-show, sl-hide, sl-after-hide events Fjernet. Bruk native close-event
sl-request-close event Fjernet. disableBackground hindrer lukking via overlay
sl-initial-focus event Fjernet. Bruk autofocus-attributtet på ønsket element
Arver fra SlDialog Arver fra LitElement

Hva er likt

  • show() / hide() metoder
  • open, label, icon, disableBackground, noHeader properties
  • Alle slots: label, default, footer, header-actions
  • Alle CSS parts og custom properties
  • Animasjoner (scale + fade)

@saldar-nve saldar-nve changed the title feat(nve-dialog)!: erstatter Shoelace med native dialog-element feat(nve-dialog): erstatter Shoelace med native dialog-element Apr 30, 2026

@anjocu anjocu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@saldar-nve saldar-nve merged commit e6bc219 into release-v5.0.0 May 21, 2026
amish1188 pushed a commit that referenced this pull request Jul 2, 2026
* feat(nve-dialog): fjernet shoelace og bruker native dialog api

* feat(nve-dialog): fjernet tilbakekompatibilitet med SL funksjoner og fikset tester. Ikon vises i header

---------

Co-authored-by: Saliq Dar <saliq.dar+twoday@twoday.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants