Add binding to unmap NvBuSurface if it has been mapped #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unmap is needed to prevent memory leaks.I.e. using get_nvds_buf_surface on Jetson Xavier NX causes memory leaks since it maps buffer to CPU but don't unmap it. See https://forums.developer.nvidia.com/t/memory-leak-on-xavier-nx/234438 for details.
tomskikh
added a commit
to insight-platform/Savant
that referenced
this pull request
Dec 14, 2022
tomskikh
added a commit
to insight-platform/Savant
that referenced
this pull request
Dec 14, 2022
tomskikh
added a commit
to insight-platform/Savant
that referenced
this pull request
Dec 14, 2022
|
Hi tomskikh, thank you for helping us improve the bindings. This repo is currently not set up to take pull requests directly but we will have bindings for NVBufSurfaceMap in our upcoming release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unmap is needed to prevent memory leaks. I.e. using
get_nvds_buf_surfaceon Jetson Xavier NX causes memory leaks since it maps buffer to CPU but don't unmap it. See https://forums.developer.nvidia.com/t/memory-leak-on-xavier-nx/234438 for details.