Skip to content

Add a GA workflow that requires labels on PR's#101

Merged
benfred merged 1 commit intomainfrom
require-label
Jun 9, 2022
Merged

Add a GA workflow that requires labels on PR's#101
benfred merged 1 commit intomainfrom
require-label

Conversation

@benfred
Copy link
Copy Markdown
Member

@benfred benfred commented Jun 9, 2022

This adds a github actions workflow that requires PR's to be
labelled as described in:

https://github.com/NVIDIA-Merlin/Merlin/blob/main/CONTRIBUTING.md#label-your-prs

Unlabelled PR's will get failed by this workflow, and once we make this
required they won't be able to be merged.

This adds a github actions workflow that requires PR's to be
labelled as described in:

https://github.com/NVIDIA-Merlin/Merlin/blob/main/CONTRIBUTING.md#label-your-prs

Unlabelled PR's will get failed by this workflow, and once we make this
required they won't be able to be merged.
@nvidia-merlin-bot
Copy link
Copy Markdown

Click to view CI Results
GitHub pull request #101 of commit c14ff2f209a1bf6e74393f32d024d005cb454227, no merge conflicts.
Running as SYSTEM
Setting status of c14ff2f209a1bf6e74393f32d024d005cb454227 to PENDING with url https://10.20.13.93:8080/job/merlin_core/69/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_core
using credential ce87ff3c-94f0-400a-8303-cb4acb4918b5
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/core # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/core
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems username and pass
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/core +refs/pull/101/*:refs/remotes/origin/pr/101/* # timeout=10
 > git rev-parse c14ff2f209a1bf6e74393f32d024d005cb454227^{commit} # timeout=10
Checking out Revision c14ff2f209a1bf6e74393f32d024d005cb454227 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f c14ff2f209a1bf6e74393f32d024d005cb454227 # timeout=10
Commit message: "Add a GA workflow that requires labels on PR's"
 > git rev-list --no-walk 9d5074c6613831db8df05a7467368b2c7350d9af # timeout=10
[merlin_core] $ /bin/bash /tmp/jenkins3447011211743618857.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_core/core, configfile: pyproject.toml
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 342 items / 1 skipped

tests/unit/core/test_dispatch.py .. [ 0%]
tests/unit/dag/test_base_operator.py .... [ 1%]
tests/unit/dag/test_column_selector.py .......................... [ 9%]
tests/unit/dag/test_tags.py ...... [ 11%]
tests/unit/dag/ops/test_selection.py ... [ 11%]
tests/unit/io/test_io.py ............................................... [ 25%]
................................................................ [ 44%]
tests/unit/schema/test_column_schemas.py ............................... [ 53%]
........................................................................ [ 74%]
....................................................................... [ 95%]
tests/unit/schema/test_schema.py ...... [ 97%]
tests/unit/schema/test_schema_io.py .. [ 97%]
tests/unit/utils/test_utils.py ........ [100%]

=============================== warnings summary ===============================
tests/unit/dag/test_base_operator.py: 4 warnings
tests/unit/io/test_io.py: 72 warnings
/usr/local/lib/python3.8/dist-packages/cudf/core/dataframe.py:1292: UserWarning: The deep parameter is ignored and is only included for pandas compatibility.
warnings.warn(

tests/unit/io/test_io.py::test_validate_and_regenerate_dataset
/var/jenkins_home/workspace/merlin_core/core/merlin/io/parquet.py:551: DeprecationWarning: 'ParquetDataset.pieces' attribute is deprecated as of pyarrow 5.0.0 and will be removed in a future version. Specify 'use_legacy_dataset=False' while constructing the ParquetDataset, and then use the '.fragments' attribute instead.
paths = [p.path for p in pa_dataset.pieces]

tests/unit/utils/test_utils.py::test_nvt_distributed[True-True]
/var/jenkins_home/.local/lib/python3.8/site-packages/distributed/node.py:160: UserWarning: Port 8787 is already in use.
Perhaps you already have a cluster running?
Hosting the HTTP server on port 40895 instead
warnings.warn(

tests/unit/utils/test_utils.py::test_nvt_distributed[True-False]
/var/jenkins_home/.local/lib/python3.8/site-packages/distributed/node.py:160: UserWarning: Port 8787 is already in use.
Perhaps you already have a cluster running?
Hosting the HTTP server on port 39255 instead
warnings.warn(

tests/unit/utils/test_utils.py::test_nvt_distributed[False-True]
/var/jenkins_home/.local/lib/python3.8/site-packages/distributed/node.py:160: UserWarning: Port 8787 is already in use.
Perhaps you already have a cluster running?
Hosting the HTTP server on port 33753 instead
warnings.warn(

tests/unit/utils/test_utils.py::test_nvt_distributed[False-False]
/var/jenkins_home/.local/lib/python3.8/site-packages/distributed/node.py:160: UserWarning: Port 8787 is already in use.
Perhaps you already have a cluster running?
Hosting the HTTP server on port 38209 instead
warnings.warn(

tests/unit/utils/test_utils.py::test_nvt_distributed_force[True]
/var/jenkins_home/.local/lib/python3.8/site-packages/distributed/node.py:160: UserWarning: Port 8787 is already in use.
Perhaps you already have a cluster running?
Hosting the HTTP server on port 43703 instead
warnings.warn(

tests/unit/utils/test_utils.py::test_nvt_distributed_force[False]
/var/jenkins_home/.local/lib/python3.8/site-packages/distributed/node.py:160: UserWarning: Port 8787 is already in use.
Perhaps you already have a cluster running?
Hosting the HTTP server on port 38337 instead
warnings.warn(

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
================= 342 passed, 1 skipped, 83 warnings in 55.97s =================
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script : #!/bin/bash
cd /var/jenkins_home/
CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://api.GitHub.com/repos/NVIDIA-Merlin/core/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"
[merlin_core] $ /bin/bash /tmp/jenkins6987379572138235056.sh

@benfred benfred added the ci label Jun 9, 2022
@benfred
Copy link
Copy Markdown
Member Author

benfred commented Jun 9, 2022

Without a label, this PR failed with :
Screen Shot 2022-06-08 at 5 23 20 PM

but add the 'CI' labelled removed that failure and shows up as success

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 9, 2022

Documentation preview

https://nvidia-merlin.github.io/core/review/pr-101

@benfred benfred added ci and removed ci labels Jun 9, 2022
@benfred benfred merged commit 78ecddd into main Jun 9, 2022
@benfred benfred deleted the require-label branch June 9, 2022 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants