Skip to content

chore(docs): configure doc preview for PRs#36

Merged
mikemckiernan merged 1 commit intoNVIDIA-Merlin:mainfrom
mikemckiernan:chore-docs-preview
Mar 9, 2022
Merged

chore(docs): configure doc preview for PRs#36
mikemckiernan merged 1 commit intoNVIDIA-Merlin:mainfrom
mikemckiernan:chore-docs-preview

Conversation

@mikemckiernan
Copy link
Copy Markdown
Member

Complete the configuration for a Sphinx build.

Add the workflow for doc previews in PRs.

@mikemckiernan mikemckiernan requested a review from karlhigley March 9, 2022 22:34
@mikemckiernan
Copy link
Copy Markdown
Member Author

mikemckiernan commented Mar 9, 2022

As with the previous two times, I don't anticipate that the docs-preview-pr workflow will run.

In terms of a check, I pushed this commit to the main branch of my fork and then opened a PR against it. It seems OK:

mikemckiernan#2

This should be OK if it is merged before a gh-pages branch is created, but someone with more privs than me needs to add it. I tried creating a separate PR to merge mikemckiernan:gh-pages, but there's nothing for GH to compare it to...doesn't seem possible to create the branch with a PR.

Copy link
Copy Markdown
Member

@benfred benfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! looks good

I'll create the gh-pages branch in a second

* Remove the `npm install...` steps that I
  failed to notice earlier.

* Rebase
@mikemckiernan mikemckiernan merged commit d674051 into NVIDIA-Merlin:main Mar 9, 2022
@mikemckiernan mikemckiernan deleted the chore-docs-preview branch March 9, 2022 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants