Schema apply to select refactor#74
Conversation
Click to view CI ResultsGitHub pull request #74 of commit ab760b1dad18b75edf61dc8788116751bc6427e5, no merge conflicts.
Running as SYSTEM
Setting status of ab760b1dad18b75edf61dc8788116751bc6427e5 to PENDING with url https://10.20.13.93:8080/job/merlin_core/35/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_core
using credential ce87ff3c-94f0-400a-8303-cb4acb4918b5
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url https://github.com/NVIDIA-Merlin/core # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/core
> git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems username and pass
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/core +refs/pull/74/*:refs/remotes/origin/pr/74/* # timeout=10
> git rev-parse ab760b1dad18b75edf61dc8788116751bc6427e5^{commit} # timeout=10
Checking out Revision ab760b1dad18b75edf61dc8788116751bc6427e5 (detached)
> git config core.sparsecheckout # timeout=10
> git checkout -f ab760b1dad18b75edf61dc8788116751bc6427e5 # timeout=10
Commit message: "fix merge conflicts"
> git rev-list --no-walk c92d16b0fadfd4f885d0b43203d0d3c69feecd8d # timeout=10
[merlin_core] $ /bin/bash /tmp/jenkins4330360244769985268.sh
Looking in indexes: https://pypi.org/simple, https://pypi.ngc.nvidia.com
Requirement already satisfied: setuptools in /usr/local/lib/python3.8/dist-packages (60.9.3)
Collecting setuptools
Downloading setuptools-62.1.0-py3-none-any.whl (1.1 MB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.1/1.1 MB 17.4 MB/s eta 0:00:00
Installing collected packages: setuptools
Attempting uninstall: setuptools
Found existing installation: setuptools 60.9.3
Uninstalling setuptools-60.9.3:
Successfully uninstalled setuptools-60.9.3
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
google-auth 1.35.0 requires cachetools<5.0,>=2.0.0, but you have cachetools 5.0.0 which is incompatible.
tensorflow-gpu 2.8.0 requires keras<2.9,>=2.8.0rc0, but you have keras 2.6.0 which is incompatible.
tensorflow-gpu 2.8.0 requires tensorboard<2.9,>=2.8, but you have tensorboard 2.6.0 which is incompatible.
Successfully installed setuptools-62.1.0
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.1, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_core/core, configfile: pyproject.toml
plugins: xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 342 items / 1 skipped
|
Documentation preview |
This PR refactors all the apply and apply_inverse calls and introduces the concept of excluding. We then propogate the use of those core functions across the schema where necessary, replacing several current APIs (i.e. remove_col, without).