Open
Conversation
Signed-off-by: memadi <memadi@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nrows) from_run_internalintoread_inputso thatpreview()reads only the requested number of rows from disk instead ofloading the full dataset and truncating afterward. For CSV this uses
pd.read_csv(nrows=…)natively; for Parquet it applieshead()after load._run_internalby removing thepreview_num_recordsparameter thatwas threaded through detection, replacement, and rewrite workflows — the
dataframe is now already the right size on entry.
reader.py(with a "Preview mode"prefix when
nrowsis set).nrowsbehavior: CSV truncation, Parquet truncation,nrows > len,nrows=None, attribute preservation, and remote-CSVforwarding. Update logging assertions to match the new log format.
Type of Change
Testing
make testpasses locallymake checkpasses locally (format + lint + typecheck + lock-check)Documentation
make docs-buildpasses locallyRelated Issues