Skip to content

docs: updating build notice#138

Merged
alexahaushalter merged 5 commits into
mainfrom
alexahaushalter/docs/build-notice-update
Apr 28, 2026
Merged

docs: updating build notice#138
alexahaushalter merged 5 commits into
mainfrom
alexahaushalter/docs/build-notice-update

Conversation

@alexahaushalter
Copy link
Copy Markdown
Contributor

@alexahaushalter alexahaushalter commented Apr 27, 2026

Summary

Updating build.nvidia.com notice per guidance from legal.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Refactoring

Testing

  • make test passes locally
  • make check passes locally (format + lint + typecheck + lock-check)
  • Added/updated tests for changes

Documentation

  • If docs changed: make docs-build passes locally

Related Issues

N/A

Signed-off-by: Alexa Haushalter <ahaushalter@nvidia.com>
@alexahaushalter alexahaushalter requested review from a team as code owners April 27, 2026 19:07
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 27, 2026

Greptile Summary

This PR updates the NVIDIA Build notice across all documentation files (README.md, docs/index.md, and all five notebook source/compiled pairs) to include legal-required language about terms of service, privacy practices, production restrictions, data upload caution, and usage logging. The wording is applied consistently across all 12 files.

Confidence Score: 5/5

Safe to merge — documentation-only change with no code impact

All changes are doc-only legal text updates, applied consistently across all 12 files. No logic, API, or behavior is affected. Only a pre-existing P2 formatting inconsistency (preview() missing backticks in README.md) was previously flagged and is not new to this PR.

No files require special attention

Important Files Changed

Filename Overview
README.md Legal notice for NVIDIA Build added; preview() is missing backtick formatting (previously flagged)
docs/index.md Legal notice updated consistently with backtick-formatted preview() inside warning admonition
docs/notebook_source/01_your_first_anonymization.py Legal notice updated consistently, preview() correctly backtick-formatted in source
docs/notebooks/01_your_first_anonymization.ipynb Compiled notebook updated to match .py source with new legal notice and preview() in backticks
docs/notebook_source/02_inspecting_detected_entities.py Legal notice updated consistently with the other notebook sources
docs/notebook_source/03_choosing_a_replacement_strategy.py Legal notice updated consistently with the other notebook sources
docs/notebook_source/04_rewriting_biographies.py Legal notice updated consistently with the other notebook sources
docs/notebook_source/05_rewriting_legal_documents.py Legal notice updated consistently with the other notebook sources
docs/notebooks/02_inspecting_detected_entities.ipynb Compiled notebook updated to match .py source with new legal notice
docs/notebooks/03_choosing_a_replacement_strategy.ipynb Compiled notebook updated to match .py source with new legal notice
docs/notebooks/04_rewriting_biographies.ipynb Compiled notebook updated to match .py source with new legal notice
docs/notebooks/05_rewriting_legal_documents.ipynb Compiled notebook updated to match .py source with new legal notice

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Legal notice update] --> B[README.md]
    A --> C[docs/index.md]
    A --> D[Notebook sources ×5
docs/notebook_source/*.py]
    A --> E[Compiled notebooks ×5
docs/notebooks/*.ipynb]
    B --> F[Updated NVIDIA Build
legal disclaimer text]
    C --> F
    D --> F
    E --> F
Loading

Reviews (5): Last reviewed commit: "docs: NVIDIA Build disclaimer in noteboo..." | Re-trigger Greptile

Comment thread docs/notebooks/01_your_first_anonymization.ipynb
@lipikaramaswamy
Copy link
Copy Markdown
Collaborator

lipikaramaswamy commented Apr 27, 2026

The updated text itself looks good but one issue

  1. The PR also commits regenerated notebook artifacts in docs/notebooks/*.ipynb. You can have cursor just go through and restore changes there.

Once fixed and merged, I'll deploy docs.

Replaces regenerated .ipynb churn with the same NVIDIA Build notice as
docs/notebook_source, touching only the two setup markdown lines per notebook.

Made-with: Cursor
Notebooks under docs/notebooks match main; NVIDIA Build disclosure lives in
docs/notebook_source/*.py plus README and docs index.

Made-with: Cursor
Signed-off-by: Alexa Haushalter <ahaushalter@nvidia.com>
@lipikaramaswamy
Copy link
Copy Markdown
Collaborator

whoops sorry what i meant was that cursor can just go through the ipynb in raw format and replace the disclaimer instead of opening the notebooks and making changes. We don't autogenerate ipynb on docs build (...yet :))

Restore .ipynb structure from main and replace only the two Setup sub-bullets
so the PR diff stays wording-only (matches docs/notebook_source).

Made-with: Cursor
Copy link
Copy Markdown
Collaborator

@lipikaramaswamy lipikaramaswamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@alexahaushalter alexahaushalter merged commit 235e843 into main Apr 28, 2026
15 of 19 checks passed
@alexahaushalter alexahaushalter deleted the alexahaushalter/docs/build-notice-update branch April 28, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants