fix(docs): publish release docs from release workflow#140
Conversation
Ensure main docs deploys only the dev version while release runs publish the versioned docs and latest alias. Signed-off-by: lipikaramaswamy <lramaswamy@nvidia.com>
Greptile SummaryThis PR fixes docs aliasing so
Confidence Score: 3/5Not safe to merge until the missing notebook-artifact step is addressed in the new release docs job. A P1 finding β the new deploy job silently deploys incomplete docs missing notebook content β pulls the score below the P1 ceiling of 4. .github/workflows/release.yml β the new Important Files Changed
Sequence DiagramsequenceDiagram
participant D as workflow_dispatch
participant RW as release.yml
participant DW as docs.yml
participant GHP as gh-pages
D->>RW: trigger (release-ref, create-gh-release=true)
RW->>RW: publish-wheel (build + upload to PyPI)
RW->>RW: create-gh-release (gh release create via GITHUB_TOKEN)
Note over DW: release event NOT fired
RW->>RW: deploy-release-docs checkout β setup-python β docs-build
Note over RW: No build-notebooks or artifact download
RW->>GHP: mike deploy VERSION latest
Note over DW: On push to main:
DW->>DW: checkout β setup-python β docs-build
DW->>GHP: mike deploy dev
Note over DW: On manual GitHub release:
DW->>DW: build-notebooks
DW->>DW: deploy-release (download notebooks β docs-build)
DW->>GHP: mike deploy VERSION latest
Reviews (1): Last reviewed commit: "fix(docs): publish release docs from rel..." | Re-trigger Greptile |
Summary
latestpointed at the newest released docs instead ofdevType of Change
Testing
make testpasses locallymake checkpasses locally (format + lint + typecheck + lock-check)Documentation
make docs-buildpasses locally