Skip to content

chore: remove unnecessary skip_health_check for GLiNER#25

Merged
lipikaramaswamy merged 3 commits into
mainfrom
andreatgretel/chore/remove-skip-health-check
Mar 6, 2026
Merged

chore: remove unnecessary skip_health_check for GLiNER#25
lipikaramaswamy merged 3 commits into
mainfrom
andreatgretel/chore/remove-skip-health-check

Conversation

@andreatgretel
Copy link
Copy Markdown
Collaborator

@andreatgretel andreatgretel commented Mar 6, 2026

Summary

Test plan

  • Health check passes without skip_health_check
  • Full pipeline runs end-to-end with default nvidia provider

@andreatgretel andreatgretel requested a review from a team as a code owner March 6, 2026 17:49
…EADME

- Remove skip_health_check: true from GLiNER config — health check passes
  now that unsupported params were removed in #24
- Fix README: NVIDIA_API_KEY (not NIM_API_KEY) is the correct env var
@andreatgretel andreatgretel force-pushed the andreatgretel/chore/remove-skip-health-check branch from 5fd3ece to 7aa53f6 Compare March 6, 2026 17:59
@andreatgretel andreatgretel requested a review from a team as a code owner March 6, 2026 17:59
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
@lipikaramaswamy lipikaramaswamy merged commit c381dfc into main Mar 6, 2026
5 checks passed
@lipikaramaswamy lipikaramaswamy deleted the andreatgretel/chore/remove-skip-health-check branch March 6, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants