refactor: unify detection and replacement label scope#44
Merged
lipikaramaswamy merged 8 commits intoMar 16, 2026
Merged
Conversation
Make Detect.entity_labels the single source of truth for label scope by using the default built-in set when omitted and only the provided labels when set. Remove replace-side label scoping and simplify the supporting config, workflow, and tests around that contract.
lipikaramaswamy
changed the title
asteier2026
approved these changes
Mar 14, 2026
Base automatically changed from
lipikaramaswamy/refactor/filtered-display-and-detection-prompts
to
main
March 16, 2026 16:45
lipikaramaswamy
deleted the
lipikaramaswamy/refactor/unify-detect-replace-label-scope
branch
This was referenced Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Detect.entity_labelsthe single source of truth for label scopeentity_labels=Noneuses the built-in defaults, while a provided list limits detection to only those labels. Further, replacement automatically operates only on entity labels specified in the detection stage.Type of Change
Testing
Note
This PR is stacked on
lipikaramaswamy/refactor/filtered-display-and-detection-promptsand should be merged after that branch lands. After the base PR merges, this PR can be retargeted tomain.