fix: tighten substitute replacement-map generation#47
Merged
lipikaramaswamy merged 3 commits intoMar 16, 2026
Conversation
asteier2026
approved these changes
Mar 16, 2026
lipikaramaswamy
deleted the
lipikaramaswamy/fix/substitute-workflow-tightening
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a
substitute()inconsistency where rows could show unchanged replaced text alongside a hallucinated non-empty replacement map. We tighten thesubstitute()workflow so replacement maps are only generated for rows with actual entities to replace. This prevents bogus replacement-map entries from appearing when_entities_by_valueis empty and keeps substitute output consistent with the detected entity set.Type of Change
Testing