feat: port developer tooling and build from Safe-Synthesizer repo#51
Merged
Conversation
Contributor
|
All contributors have signed the DCO ✍️ ✅ |
This was referenced Mar 17, 2026
binaryaaron
force-pushed
the
infra/pr1-foundation
branch
from
875179a to
c68feb1
Compare
mckornfield
approved these changes
Mar 20, 2026
mckornfield
changed the title
mckornfield
changed the title
…e-Synthesizer Foundation infrastructure for NeMo Anonymizer: - Port tools/binaries/ (bootstrap scripts for uv, ty, yq, gh) and tools/codestyle/ (format, lint, typecheck, copyright scripts) - Extract ruff config to standalone ruff.toml with stricter rules commented out for future adoption - Update pyproject.toml: add docs dep group, add ty to dev deps, switch to uv-dynamic-versioning for git-tag-based versioning, add pytest markers - Overhaul .pre-commit-config.yaml: replace upstream ruff hooks with local script hooks, add DCO signoff check, uv-lock check, typecheck, copyright fix - Rewrite Makefile with new targets: bootstrap-tools, bootstrap, format, format-check, typecheck, check, lock-check, test-slow, test-e2e, build-wheel, publish-internal, publish-pypi, test-container - Create .python-version, .copyrightignore, .vscode/settings.json - Add container smoke test (test_tool_install.sh) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: aagonzales <aagonzales@nvidia.com> Made-with: Cursor
- Pin ty>=0.0.23,<0.1 in dev deps - Exclude tools/ from ty checking (PEP 723 inline-script deps) - Make typecheck non-blocking in pre-commit (|| true) and Makefile (-) - 41 diagnostics remain -- tracked in a follow-up issue Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: aagonzales <aagonzales@nvidia.com> Made-with: Cursor
Address review feedback: - Remove tools/binaries/ (bootstrap toolchain) -- dev tools come from uv sync --group dev, no standalone binary management needed - Remove tools/diff-lockfile.py (not needed for small dep surface) - Remove .vscode/settings.json (PATH prepend was for standalone bins) - Simplify _lib.sh: remove version-checking that depended on yq/tools.yaml - Fix format-check: was only running ruff check (lint), now also runs ruff format --check (formatting verification) - Remove test-slow target (no slow-marked tests exist) - Remove publish-internal target (no Artifactory target for Anonymizer) - Remove test-container target (validated removed bootstrap infra) - Add uv run prefix to typecheck invocations Signed-off-by: aagonzales <aagonzales@nvidia.com> Made-with: Cursor
…e CONTRIBUTING.md (#52) - Create mkdocs.yml with material theme, mkdocstrings, gen-files, literate-nav, mkdocs-jupyter, griffe-pydantic, mike versioning, and blog plugin (devnotes/) - Add docs/ tree: index.md, getting-started, architecture with mermaid diagrams, API reference pages, CSS/JS assets, devnotes blog scaffold - Add gen_ref_pages.py for auto-generated API reference - Add Makefile targets: install-dev-docs, docs-serve, docs-build - Update CONTRIBUTING.md with new setup, testing, code style, and documentation sections Made-with: Cursor Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: aagonzales <aagonzales@nvidia.com>
mckornfield
force-pushed
the
infra/pr1-foundation
branch
from
13d492a to
92e4754
Compare
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
Collaborator
|
re docs: temporary scaffolding looks fine, and I'll follow up with the actual Anonymizer-specific content. We do have some small dups cleanup to do tho |
Contributor
|
believe I pushed, want to take a final look? |
lipikaramaswamy
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Foundation infrastructure PR that ports developer tooling from Safe-Synthesizer and adapts it for Anonymizer.
Key files created/changed
tools/binaries/-- bootstrap scripts for standalone tools (uv, ty, yq, gh)tools/codestyle/-- format, lint, typecheck, copyright enforcement scriptsruff.toml-- extracted from pyproject.toml; stricter rules commented out for gradual adoptionpyproject.toml-- docs dep group, ty in dev deps, uv-dynamic-versioning, pytest markers.pre-commit-config.yaml-- local hooks (format, typecheck, copyright-fix, uv-lock, DCO signoff)Makefile-- new targets: bootstrap-tools, bootstrap, format, format-check, typecheck, check, lock-check, test-slow, test-e2e, build-wheel, publish-internal, publish-pypi, test-container.python-version,.copyrightignore,.vscode/settings.jsontools/binaries/test_tool_install.sh-- container smoke testKey decisions
uv runin the venv.uv run-- ensures consistent ruff/ty versions from the venv.vscode/settings.jsonis force-added despite.vscode/being in .gitignore (same approach as Safe-Synthesizer)uv run --scriptTesting
uv sync --group devsucceedsMade with Cursor