fix: cap preview_num_records to entity row count in replace workflow#59
Merged
Merged
Conversation
asteier2026
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
preview()is called withSubstitutereplacement,llm_replace_workflow.pyfilters the input down to only entity-bearing rows before passing to the adapter. Previously it passed the originalpreview_num_records(total dataset size) unchanged, causing Data Designer's seed generator to wrap around and produce duplicate rows.The fix caps
preview_num_recordstolen(entity_rows)before the adapter call.Type of Change
Testing
The fix is a one-liner capping a value passed to a mocked dependency. A unit test would only assert that
min()works, not that duplicates are actually prevented — the real invariant lives at the Data Designer seed wrap-around boundary which requires a live NIM endpoint to exercise.Related Issues
Closes #58