refactor: extract shared row-partitioning helpers#79
Merged
Conversation
Move the duplicated split/reorder/recombine pattern into engine/row_partitioning.py with split_rows() and merge_and_reorder(). Refactor rewrite_workflow.py and llm_replace_workflow.py to use the shared helpers instead of inline implementations. Closes #60
- Make ROW_ORDER_COL public so tests can import it - Add guard for empty parts in merge_and_reorder - Add test for empty-parts guard - Strengthen roundtrip test assertion on val column
lipikaramaswamy
approved these changes
Mar 31, 2026
Collaborator
lipikaramaswamy
left a comment
lipikaramaswamy
left a comment
There was a problem hiding this comment.
Looks good, just a few nits and suggestions. e2e test ran without issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
engine/row_partitioning.pymodule withsplit_rows()andmerge_and_reorder()rewrite_workflow.pyandllm_replace_workflow.pyto use the shared helpers instead of inline implementationsCloses #60
Test plan
row_partitioning.py(partitioning, edge cases, roundtrip)ruff check)