Skip to content

docs: add step to activate venv#90

Merged
nina-xu merged 5 commits into
mainfrom
nina-xu/docs-activate-venv
Apr 6, 2026
Merged

docs: add step to activate venv#90
nina-xu merged 5 commits into
mainfrom
nina-xu/docs-activate-venv

Conversation

@nina-xu
Copy link
Copy Markdown
Contributor

@nina-xu nina-xu commented Apr 2, 2026

Summary

Another quick one, haha

@nina-xu nina-xu requested a review from a team as a code owner April 2, 2026 16:15
@nina-xu nina-xu changed the title add step to activate venv docs:add step to activate venv Apr 2, 2026
@nina-xu nina-xu changed the title docs:add step to activate venv docs: add step to activate venv Apr 2, 2026
@lipikaramaswamy
Copy link
Copy Markdown
Collaborator

source .venv/bin/activate is needed only if you prefer a traditional activated environment. All our make commands use uv run.

@nina-xu
Copy link
Copy Markdown
Contributor Author

nina-xu commented Apr 3, 2026

source .venv/bin/activate is needed only if you prefer a traditional activated environment. All our make commands use uv run.

it's only that all the CLI commands in step 3 don't work unless the env is activated. if you want to add uv run to those commands, that's fine too. whatever makes the readme examples just work if they follow it exactly

Comment thread README.md
Comment thread README.md Outdated
nina-xu and others added 2 commits April 6, 2026 13:32
Co-authored-by: lipikaramaswamy <31832945+lipikaramaswamy@users.noreply.github.com>
Comment thread README.md Outdated
nina-xu added 2 commits April 6, 2026 13:34
Signed-off-by: ninaxu <ninaxu@nvidia.com>
@nina-xu nina-xu requested a review from lipikaramaswamy April 6, 2026 17:44
Copy link
Copy Markdown
Collaborator

@lipikaramaswamy lipikaramaswamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for flagging this!!

@nina-xu nina-xu merged commit e53b5de into main Apr 6, 2026
8 checks passed
@nina-xu nina-xu deleted the nina-xu/docs-activate-venv branch April 6, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants