Skip to content

chore(ci): line up CI with fixes in safe-synthesizer repo#93

Merged
mckornfield merged 2 commits into
mainfrom
line-up-ci/mck
Apr 6, 2026
Merged

chore(ci): line up CI with fixes in safe-synthesizer repo#93
mckornfield merged 2 commits into
mainfrom
line-up-ci/mck

Conversation

@mckornfield
Copy link
Copy Markdown
Contributor

  • After doing some last minute release fixes for safe-synthesizer, this
    brings in some of those changes

@mckornfield mckornfield requested a review from a team as a code owner April 3, 2026 21:17
Comment thread pyproject.toml
Comment thread .github/workflows/release.yml Outdated
Comment thread .github/workflows/release.yml Outdated
@mckornfield
Copy link
Copy Markdown
Contributor Author

As a pre-req for running this pipeline, we need:

TEST_PYPI_PERSONAL_TOKEN and PYPI_PERSONAL_TOKEN added to secrets, which represent pypi tokens made by whoever is going to control the repo (could be a data-designer-team style one, or just a personal account tied to a person)

@lipikaramaswamy
Copy link
Copy Markdown
Collaborator

As a pre-req for running this pipeline, we need:

TEST_PYPI_PERSONAL_TOKEN and PYPI_PERSONAL_TOKEN added to secrets, which represent pypi tokens made by whoever is going to control the repo (could be a data-designer-team style one, or just a personal account tied to a person)

Got these in
image

@mckornfield
Copy link
Copy Markdown
Contributor Author

Sweet... once this merges, the steps are:
(1) create the tag
(2) run the job with the tag as an input

image

We could follow up where just pushing the tag does the release too, and maybe sends it to test.pypi and regular pypi, but up to you. I don't love decoupling them but it was good while figuring things out

Copy link
Copy Markdown
Collaborator

@lipikaramaswamy lipikaramaswamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mckornfield mckornfield merged commit 6af0e19 into main Apr 6, 2026
8 checks passed
@mckornfield mckornfield deleted the line-up-ci/mck branch April 6, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants