chore: upgrade data-designer to 0.5.5#95
Conversation
|
The So thinking about the global-state interaction here -- One possible workaround would be to scope |
|
Also, Related IssuesCloses #87 |
- Bump data-designer dependency from 0.5.0 to 0.5.5 - Work around DD logging override (NVIDIA-NeMo/DataDesigner#388): reapply Anonymizer's logger levels after DataDesigner init - Fix stale data path in e2e test (docs/notebook_source/data -> docs/data) - Clean up e2e test: default logging, assertions, run as script
…ig on enabled=False - configure_logging(enabled=False) now clears _active_config so reapply_log_levels() cannot act on stale prior config - reapply_log_levels() only runs when Anonymizer creates its own DataDesigner, not when a pre-configured instance is passed in - Add test for the enabled=False path
74c238b to
2856bc7
Compare
|
@lipikaramaswamy Good catch — you're right that the notebook/long-lived process scenario makes this a real concern. Addressed in the latest push:
|
|
Never mind, I had set DATA_DESIGNER_ASYNC_ENGINE=1 🙃 All good without that envvar. I will go ahead and merge. |
Summary
data-designerfrom 0.5.0 to 0.5.5_initialize_interface_runtime()now callsconfigure_logging()duringDataDesigner.__init__(), which overwrites thedata_designerlogger level and noisy-logger suppression that Anonymizer sets up. We re-apply our logger levels after constructingDataDesignerviareapply_log_levels().tests_e2e/test_e2e.py(see below)Closes #87
E2E test changes
The original e2e test was a script that ran the full pipeline on all 25 records with debug logging. In practice this took 15+ minutes, produced very verbose output, and had no assertions - making it hard to tell whether things were passing or stuck.
Changes:
docs/notebook_source/data/no longer exists, data moved todocs/data/)preview()vscreate(), which is a DD concern, not Anonymizer's.test-e2etarget to run the script directlyTest plan
data_designerlogger stays at WARNING afterAnonymizer()init