docs: update notebook csv inputs#96
Merged
Merged
Conversation
…ative paths, update io / config to accept http(s) input csv or parquet
kendrickb-nvidia
approved these changes
Apr 7, 2026
andreatgretel
approved these changes
Apr 7, 2026
Collaborator
andreatgretel
left a comment
andreatgretel
left a comment
There was a problem hiding this comment.
LGTM!
couple small things:
-
ftp://example.com/data.csvfalls through to local path validation and gives"Input path does not exist: ftp:/example.com/data.csv"- a guard for unsupported URL schemes invalidate_source_pathwould give a clearer error -
the remote URL error paths (unsupported extension, network failure) don't have test coverage - the existing error-path tests only exercise local files
nothing blocking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the docs notebooks to load sample datasets from GitHub raw URLs instead of repo-relative paths, so they work outside a local checkout. Also updates input validation and reader logic to accept HTTP(S) CSV and Parquet sources, with focused tests covering the new behavior.
Type of Change
Testing
make testpasses locallymake checkpasses locally (format + lint + typecheck + lock-check) - except tyDocumentation
make docs-buildpasses locally