feat: add option to optimize pp shape inference#1195
Merged
Conversation
hemildesai
requested review from
HuiyingLi,
adil-a and
akoumpa
as code owners
Contributor
Author
|
/ok to test ceb5184 |
Signed-off-by: Hemil Desai <hemild@nvidia.com>
hemildesai
force-pushed
the
hemil/pp-opts
branch
from
ceb5184 to
907123d
Compare
Contributor
Author
|
/ok to test 907123d |
Contributor
Author
|
/ok to test d2e8790 |
linnanwang
pushed a commit
that referenced
this pull request
Apr 24, 2026
* feat: add option to optimize pp shape inference Signed-off-by: Hemil Desai <hemild@nvidia.com> * fix Signed-off-by: Hemil Desai <hemild@nvidia.com> * fix Signed-off-by: Hemil Desai <hemild@nvidia.com> * fix Signed-off-by: Hemil Desai <hemild@nvidia.com> --------- Signed-off-by: Hemil Desai <hemild@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With optimization: https://wandb.ai/Nemo-automodel/automodel-finetunes-2026-01-26/runs/21pf95tl
Without: https://wandb.ai/Nemo-automodel/automodel-finetunes-2026-01-26/runs/c2skkqcl
First step time starts 3-4 minutes early, can be inferred from the logs in the above links.