Merged
Conversation
Contributor
Author
|
/ok to test 8915726 |
Contributor
Author
|
/ok to test 750f55a |
Contributor
Author
|
/ok to test dad2a6f |
Contributor
Author
|
/ok to test 90eae91 |
hemildesai
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
TestMoELoRASaveRestoreMergeHFcovers -- the exact workflow from issue #1226:test_peft_loads_adapter-- Grouped LoRA tensors are converted to per-expert HF format, saved as adapter_model.safetensors + adapter_config.json, andPeftModel.from_pretrained()loads them without error.test_merge_changes_all_expert_weights-- Aftermerge_and_unload(), every expert'sgate_proj,up_proj, anddown_projweights differ from the base (all 24 = 2 layers x 4 experts x 3 projections).test_merge_values_are_numerically_correct-- The merged weight values exactly satisfyW_merged = W_base + (lora_B @ lora_A) * (alpha / r), verifying the LoRA delta is correctly applied.test_merge_removes_lora_params-- After merge, no lora_ parameters or modules remain in the model.Changelog
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information