feat: add ty for attention/config/launcher/loggers/optim#1445
Merged
Conversation
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>
Contributor
Author
|
/ok to test 94b3980 |
Contributor
|
Can we use https://github.com/astral-sh/ty which is 10-100x faster than mypy? |
akoumpa
requested review from
a team,
HuiyingLi,
ZhiyuLi-Nvidia,
adil-a and
hemildesai
as code owners
Contributor
Author
|
/ok to test e6bdecc |
Contributor
Author
|
@thomasdhc my bad, i've included a stage in 10fe6eb |
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Contributor
Author
|
/ok to test bf31c27 |
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Contributor
Author
|
/ok to test 21e3079 |
adil-a
approved these changes
Mar 5, 2026
thomasdhc
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Adding mypy type checking for attention/config/launcher/loggers/optim components.
The goal is to have all components use mypy, but this will happen gradually in follow up PRs, since there are complex components.
Changelog
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information