feat: add new score func and pp microbatch pixel split handling#1513
Merged
feat: add new score func and pp microbatch pixel split handling#1513
Conversation
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
HuiyingLi
requested review from
ZhiyuLi-Nvidia,
adil-a,
akoumpa and
hemildesai
as code owners
…litting Add tests for: - Gate forward pass with softmax_with_bias score function (basic, with groups, without correction bias) - VLM pixel_values chunking with image_sizes fallback (Mistral4-style) - VLM pixel_values chunking for 4D [N,C,H,W] tensors Signed-off-by: HuiyingLi <willwin.lee@gmail.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
Contributor
Author
|
/ok to test 615004d |
hemildesai
approved these changes
Mar 10, 2026
linnanwang
pushed a commit
that referenced
this pull request
Apr 24, 2026
* add new score func and microbatch split handling Signed-off-by: HuiyingLi <willwin.lee@gmail.com> * test: add unit tests for softmax_with_bias gate and VLM microbatch splitting Add tests for: - Gate forward pass with softmax_with_bias score function (basic, with groups, without correction bias) - VLM pixel_values chunking with image_sizes fallback (Mistral4-style) - VLM pixel_values chunking for 4D [N,C,H,W] tensors Signed-off-by: HuiyingLi <willwin.lee@gmail.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: HuiyingLi <willwin.lee@gmail.com> --------- Signed-off-by: HuiyingLi <willwin.lee@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Changelog
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information