Skip to content

fix: baichuan .bin ckpt loading#1515

Merged
akoumpa merged 15 commits intomainfrom
akoumparouli/fix_baichuan
Mar 12, 2026
Merged

fix: baichuan .bin ckpt loading#1515
akoumpa merged 15 commits intomainfrom
akoumparouli/fix_baichuan

Conversation

@akoumpa
Copy link
Copy Markdown
Contributor

@akoumpa akoumpa commented Mar 10, 2026

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Add specific line by line info of high level changes in this PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

@akoumpa
fix baichuan .bin ckpt loading
fcd8b40 
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
This was linked to issues Mar 10, 2026
from_pretrained fails for models without model.safetensors on transformers 5.x (e.g. Baichuan2-7B-Chat) #1511
Closed
Infinite recursion in _build_model/_retry when model loading fails deterministically #1510
Closed
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Mar 10, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@akoumpa
test
53a091d 
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa
Copy link
Copy Markdown
Contributor Author

akoumpa commented Mar 10, 2026

/ok to test 53a091d

@akoumpa akoumpa marked this pull request as ready for review March 10, 2026 20:25
@akoumpa
add baichuan
167c447 
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
akoumpa added 2 commits March 11, 2026 10:18
@akoumpa
allow specifiying dtype
b9014ad 
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa
step
06d3e9a 
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa
Copy link
Copy Markdown
Contributor Author

akoumpa commented Mar 11, 2026

/ok to test 06d3e9a

@akoumpa
Copy link
Copy Markdown
Contributor Author

akoumpa commented Mar 11, 2026

/ok to test a20f222

@akoumpa
Copy link
Copy Markdown
Contributor Author

akoumpa commented Mar 11, 2026

/ok to test 01b5b8b

akoumpa added 2 commits March 11, 2026 18:09
@akoumpa
simplify test
895ee89 
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa
fix inherti
eb1b214 
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa
Copy link
Copy Markdown
Contributor Author

akoumpa commented Mar 12, 2026

/ok to test eb1b214

akoumpa added 2 commits March 12, 2026 00:09
@akoumpa
track
7586f24 
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa
unit
9e62366 
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa
Copy link
Copy Markdown
Contributor Author

akoumpa commented Mar 12, 2026

/ok to test 9e62366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HuiyingLi HuiyingLi HuiyingLi approved these changes

@adil-a adil-a Awaiting requested review from adil-a adil-a is a code owner

@hemildesai hemildesai Awaiting requested review from hemildesai hemildesai is a code owner

@ZhiyuLi-Nvidia ZhiyuLi-Nvidia Awaiting requested review from ZhiyuLi-Nvidia ZhiyuLi-Nvidia is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@akoumpa @HuiyingLi