Skip to content

ci: add default env vars ala .github/actions/test-template/action.yml L120#1523

Merged
akoumpa merged 1 commit intomainfrom
akoumparouli/ci_default_hf_env_vars
Mar 11, 2026
Merged

ci: add default env vars ala .github/actions/test-template/action.yml L120#1523
akoumpa merged 1 commit intomainfrom
akoumparouli/ci_default_hf_env_vars

Conversation

@akoumpa
Copy link
Copy Markdown
Contributor

@akoumpa akoumpa commented Mar 11, 2026

What does this PR do ?

Developers who run the tests locally, have to pass HF_HOME/HF_CACHE manually.

Instead of hardcoding them everywhere (brittle if dev in multiple projects), this PR introduces default environment variables, allowing developers who have the above paths mounted on their dev machine to invoke pytest without having to pass custom environment variables.

Changelog

  • Add specific line by line info of high level changes in this PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Mar 11, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@akoumpa
Copy link
Copy Markdown
Contributor Author

akoumpa commented Mar 11, 2026

/ok to test ed4a3cb

@akoumpa akoumpa marked this pull request as ready for review March 11, 2026 17:47
@akoumpa akoumpa requested a review from thomasdhc March 11, 2026 21:21
@akoumpa akoumpa merged commit 2466961 into main Mar 11, 2026
54 checks passed
@akoumpa akoumpa deleted the akoumparouli/ci_default_hf_env_vars branch March 11, 2026 21:35
linnanwang pushed a commit that referenced this pull request Apr 24, 2026
… L120 (#1523)

add default env vars ala .github/actions/test-template/action.yml L120

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants