Skip to content

feat: add v4_compatible ckpt#1532

Merged
thomasdhc merged 10 commits intomainfrom
akoumparouli/feat_opt_in_v4
Mar 12, 2026
Merged

feat: add v4_compatible ckpt#1532
thomasdhc merged 10 commits intomainfrom
akoumparouli/feat_opt_in_v4

Conversation

@akoumpa
Copy link
Copy Markdown
Contributor

@akoumpa akoumpa commented Mar 12, 2026

What does this PR do ?

Model checkpoint assets such as config.json are not backwards compatible with transformers v4.

This PR introduces a workaround to support v4-compatible config.json on transformers v5.
Runtime-model config modifications (apart from quantization) will not be honored when using the v4_compatible flag.

Use this with caution.

Changelog

  • Add specific line by line info of high level changes in this PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Mar 12, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@akoumpa
Copy link
Copy Markdown
Contributor Author

akoumpa commented Mar 12, 2026

/ok to test a5c925a

@akoumpa
Copy link
Copy Markdown
Contributor Author

akoumpa commented Mar 12, 2026

/ok to test 0259367

@akoumpa
Copy link
Copy Markdown
Contributor Author

akoumpa commented Mar 12, 2026

/ok to test 0259367

akoumpa and others added 5 commits March 11, 2026 21:39
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
akoumpa added 3 commits March 11, 2026 23:48
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa
Copy link
Copy Markdown
Contributor Author

akoumpa commented Mar 12, 2026

/ok to test 4014566

@akoumpa akoumpa added r0.3.0 Add for cherry-pick into release branch r0.3.0 i-customizer Customizer Microservices request labels Mar 12, 2026
Comment thread nemo_automodel/components/checkpoint/checkpointing.py
@akoumpa akoumpa requested a review from hemildesai March 12, 2026 16:11
Copy link
Copy Markdown
Contributor

@thomasdhc thomasdhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, skip codecov

@thomasdhc thomasdhc disabled auto-merge March 12, 2026 16:14
@thomasdhc thomasdhc merged commit 3dc90a0 into main Mar 12, 2026
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i-customizer Customizer Microservices request r0.3.0 Add for cherry-pick into release branch r0.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants