feat: input validation & model capability#1542
Merged
Conversation
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Contributor
Author
|
/ok to test 6a6fe26 |
Contributor
Author
|
/ok to test 125ebdc |
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Contributor
Author
|
/ok to test aa9aec1 |
Contributor
Author
|
/ok to test 2fb9709 |
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Contributor
Author
|
/ok to test 4a32efd |
Contributor
Author
|
/ok to test 7da29da |
adil-a
previously approved these changes
Mar 17, 2026
Contributor
Author
|
/ok to test ac100ab |
Contributor
Author
|
/ok to test ab0746d |
Contributor
Author
|
/claude review |
Contributor
Author
|
/ok to test 654b9ad |
adil-a
approved these changes
Mar 17, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Example:
Introduces a model capabilities mixin, which allows users to query a model instance for the following attributes:
model.The above information is used together with current device_mesh configuration to validate whether the input parallelism configuration is valid or not.
Additionally, at the train loop level, we can check for things like context parallelism + sequence packing support.
Changelog
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information